-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: upgrade go to 1.22.3 #17975
Conversation
Hi @lavishpal. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@dims: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@lavishpal: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lavishpal, thanks for raising this. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e:
git rebase HEAD~1 --signoff
git push --force
Thanks!
Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change
/ok-to-test
@lavishpal I believe in the mod files within the codebase, there are lots of |
Sure i will change them also. |
33eedd3
to
df9f768
Compare
Do I need to do this for dco support for every commit? |
Yes! :) |
Hey @lavishpal I think there are still missing some updates in the mod file commit! For all these go mod files, we need bump the go toolchain version!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good. @lavishpal can you please squash the three commits into one so we can merge, i.e.
git reset --soft HEAD~3
git commit -s -m "Upgrade go to 1.22.3."
git push --force
Sure |
Signed-off-by: Lavish pal <[email protected]>
319ac3c
to
6038f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @lavishpal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @lavishpal.
Bump go version to 1.22.3 Part of #17964
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.