Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: upgrade go to 1.22.3 #17975

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

lavishpal
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @lavishpal. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims
Copy link
Contributor

dims commented May 9, 2024

/ok-to-test

@k8s-ci-robot
Copy link

@dims: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

@lavishpal: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lavishpal, thanks for raising this. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Thanks!

Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change

/ok-to-test

@henrybear327
Copy link
Contributor

@lavishpal I believe in the mod files within the codebase, there are lots of toolchain go1.22.2 that also require updating!

@lavishpal
Copy link
Contributor Author

@lavishpal I believe in the mod files within the codebase, there are lots of toolchain go1.22.2 that also require updating!

Sure i will change them also.

@lavishpal lavishpal force-pushed the upgrade/go-to-1.22.3 branch from 33eedd3 to df9f768 Compare May 9, 2024 19:45
@lavishpal
Copy link
Contributor Author

Hi @lavishpal, thanks for raising this. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Thanks!

Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change

/ok-to-test

Do I need to do this for dco support for every commit?

@henrybear327
Copy link
Contributor

Hi @lavishpal, thanks for raising this. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e:

git rebase HEAD~1 --signoff
git push --force

Thanks!
Ref: https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#commit-your-change
/ok-to-test

Do I need to do this for dco support for every commit?

Yes! :)

@henrybear327
Copy link
Contributor

@lavishpal I believe in the mod files within the codebase, there are lots of toolchain go1.22.2 that also require updating!

Sure i will change them also.

Hey @lavishpal I think there are still missing some updates in the mod file commit!

For all these go mod files, we need bump the go toolchain version!

./etcdutl/go.mod:toolchain go1.22.2
./go.mod:toolchain go1.22.2
./tools/testgrid-analysis/go.mod:toolchain go1.22.2
./tools/rw-heatmaps/go.mod:toolchain go1.22.2
./tools/mod/go.mod:toolchain go1.22.2
./etcdctl/go.mod:toolchain go1.22.2
./tests/go.mod:toolchain go1.22.2
./server/go.mod:toolchain go1.22.2
./api/go.mod:toolchain go1.22.2
./client/internal/v2/go.mod:toolchain go1.22.2
./client/v3/go.mod:toolchain go1.22.2
./client/pkg/go.mod:toolchain go1.22.2
./pkg/go.mod:toolchain go1.22.2

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good. @lavishpal can you please squash the three commits into one so we can merge, i.e.

git reset --soft HEAD~3
git commit -s -m "Upgrade go to 1.22.3."
git push --force

@lavishpal
Copy link
Contributor Author

Changes are looking good. @lavishpal can you please squash the three commits into one so we can merge, i.e.

git reset --soft HEAD~3
git commit -s -m "Upgrade go to 1.22.3."
git push --force

Sure

Signed-off-by: Lavish pal <[email protected]>
@lavishpal lavishpal force-pushed the upgrade/go-to-1.22.3 branch from 319ac3c to 6038f39 Compare May 9, 2024 21:57
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @lavishpal

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @lavishpal.

@jmhbnz jmhbnz merged commit 58a71a2 into etcd-io:main May 10, 2024
44 checks passed
@lavishpal lavishpal deleted the upgrade/go-to-1.22.3 branch May 10, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants